-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Environment variables are now parsed for boolean, integer, array and object setting values #2637
Open
edgarrmondragon
wants to merge
5
commits into
main
Choose a base branch
from
1896-break-support-the-same-env-var-formats-as-meltano
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Environment variables are now parsed for boolean, integer, array and object setting values #2637
edgarrmondragon
wants to merge
5
commits into
main
from
1896-break-support-the-same-env-var-formats-as-meltano
+117
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2637 +/- ##
==========================================
- Coverage 89.86% 89.85% -0.01%
==========================================
Files 58 58
Lines 4886 4901 +15
Branches 960 963 +3
==========================================
+ Hits 4391 4404 +13
- Misses 344 346 +2
Partials 151 151 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2637 will not alter performanceComparing Summary
|
@dependabot rebase |
edgarrmondragon
force-pushed
the
1896-break-support-the-same-env-var-formats-as-meltano
branch
from
September 2, 2024 15:58
6ae6e49
to
86a00e8
Compare
…y and object setting values
edgarrmondragon
force-pushed
the
1896-break-support-the-same-env-var-formats-as-meltano
branch
from
September 2, 2024 15:58
86a00e8
to
b352fd3
Compare
edgarrmondragon
added
the
Documentation
Improvements or additions to documentation
label
Sep 4, 2024
edgarrmondragon
added
Needs Documentation
and removed
Documentation
Improvements or additions to documentation
labels
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
📚 Documentation preview 📚: https://meltano-sdk--2637.org.readthedocs.build/en/2637/