Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Environment variables are now parsed for boolean, integer, array and object setting values #2637

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 2, 2024

Related:


📚 Documentation preview 📚: https://meltano-sdk--2637.org.readthedocs.build/en/2637/

@edgarrmondragon edgarrmondragon linked an issue Sep 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (6708cb9) to head (592ffcd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.01%     
==========================================
  Files          58       58              
  Lines        4886     4901      +15     
  Branches      960      963       +3     
==========================================
+ Hits         4391     4404      +13     
- Misses        344      346       +2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #2637 will not alter performance

Comparing 1896-break-support-the-same-env-var-formats-as-meltano (592ffcd) with main (6708cb9)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon
Copy link
Collaborator Author

@dependabot rebase

@edgarrmondragon edgarrmondragon force-pushed the 1896-break-support-the-same-env-var-formats-as-meltano branch from 6ae6e49 to 86a00e8 Compare September 2, 2024 15:58
@edgarrmondragon edgarrmondragon force-pushed the 1896-break-support-the-same-env-var-formats-as-meltano branch from 86a00e8 to b352fd3 Compare September 2, 2024 15:58
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 2, 2024 16:00
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 2, 2024 16:00
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Sep 2, 2024
@edgarrmondragon edgarrmondragon added the Documentation Improvements or additions to documentation label Sep 4, 2024
@edgarrmondragon edgarrmondragon self-assigned this Sep 4, 2024
@edgarrmondragon edgarrmondragon added Needs Documentation and removed Documentation Improvements or additions to documentation labels Sep 4, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.41.0, v0.42.0 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break: Support the same env var formats as Meltano
1 participant